Nmc/1992 sharing #84
Closed
Nmc/1992 sharing #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| var actions = [NCMenuAction]() | ||
|
|
||
| if share.shareType == 3, canReshare { | ||
|
|
| @objc func cancelClicked() { | ||
| delegate?.dismissShareAdvanceView(shouldSave: false) | ||
| } | ||
|
|
||
| labelQuickStatus.isHidden = true | ||
| imageDownArrow.isHidden = true | ||
| buttonMenu.isHidden = true | ||
| isUserInteractionEnabled = false |
There was a problem hiding this comment.
No need to format the existing NC code as it will be considered as our customization.
| isUserInteractionEnabled = false | ||
| switchCanEdit.isHidden = true | ||
| labelCanEdit.isHidden = true | ||
| buttonMenu.isHidden = true |
There was a problem hiding this comment.
Same here no need to reformat this too.
|
Check if any code can be upstreamed to NC like DownloadLimit. Same: check for other PRs where any code can be upstreamed to reduce customization. |
TSI-amrutwaghmare
force-pushed
the
nmc/1992-sharing
branch
2 times, most recently
from
754ee45
to
86e0c3a
Compare
…er app in background
…on color in dark mode
TSI-amrutwaghmare
force-pushed
the
nmc/1992-sharing
branch
from
e1f4e86
to
6386b22
Compare
TSI-amrutwaghmare
added
approved
and removed
approved
custom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Contains following modifications: